Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Lock dependencies for python-level tests #1163

Merged
merged 2 commits into from
Feb 21, 2022
Merged

ci: Lock dependencies for python-level tests #1163

merged 2 commits into from
Feb 21, 2022

Conversation

paulgessinger
Copy link
Member

They are currently not locked, and I have a slight suspicion that this is the cause for the vertexing reproducibility test failing sporadically at the moment.

@paulgessinger
ci: Lock dependencies for python-level tests
f0748b8 
They are currently not locked, and I have a slight suspicion that this
is the cause for the vertexing reproducibility test failing sporadically
at the moment.
@paulgessinger paulgessinger added this to the next milestone Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #1163 (8c33d80) into main (de6af39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files         359      359           
  Lines       18504    18504           
  Branches     8730     8730           
=======================================
  Hits         8863     8863           
  Misses       3605     3605           
  Partials     6036     6036

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6af39...8c33d80. Read the comment docs.

stephenswat
stephenswat approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Perhaps, at some point, a more full-fledged Python dependency like Poetry could be helpful, but this should be fine for now.

@stephenswat stephenswat added automerge Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module labels Feb 21, 2022
@paulgessinger
Copy link
Member Author

I use poetry a lot, but for this project I feel we should stick to just pip and requirements.txt. I use pip-compile from pip-tools to get (some of the) locking benefits that poetry provides.

@kodiakhq kodiakhq bot merged commit f407b53 into acts-project:main Feb 21, 2022
@paulgessinger paulgessinger deleted the ci/lock_python_test_deps branch February 22, 2022 08:13
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
automerge Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
v17.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulgessinger @stephenswat